[Run] Improve error MessageBox #34564
Open
+34
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@davidegiacometti |
|
I'll check. Thanks for pointing out this. |
This comment has been minimized.
This comment has been minimized.
|
|
|
I have verified and one plugin error dialog was addressed in #25095. |
davidegiacometti
force-pushed
the
users/davidegiacometti/run-error-msgbox
branch
from
9ee52f5
to
67be391
Compare
|
@davidegiacometti
|
htcfreek
approved these changes
Sep 7, 2024
htcfreek
suggested changes
Sep 7, 2024
Co-authored-by: Heiko <[email protected]>
htcfreek
approved these changes
Sep 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
This is not a fix to the error, but an improvement to MessageBox error title since it's not clear to the user that the it's related to PT Run.
This was partially addressed by #25095, but not for all the errors.
PR Checklist
Detailed Description of the Pull Request / Additional comments
MessageBox.Show(...)errors that could be triggered on startup, detecting which need to explicit call out "PT Run"IPublicAPI.ShowMsg(...)dialogs need "PT Run" in title since they are usually showed as a response to a user interaction (example click on a result or action).Validation Steps Performed